Fix StackOverflowError on resolving types with TypeVariable recursion #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample failing code:
private static class TestType<X> {
TestType<? super X> superType;
}
...
new Gson().getAdapter(TestType.class);
|
👍 |
|
Thank you for a test that demonstrates the problem! |
Closed
sebasjm
pushed a commit
to sebasjm/gson
that referenced
this pull request
Mar 11, 2018
…google#1128) * Fix StackOverflowError on resolving types with TypeVariable recursion Sample failing code: private static class TestType<X> { TestType<? super X> superType; } ... new Gson().getAdapter(TestType.class); * fix build errors
ZacSweers
added a commit
to square/moshi
that referenced
this pull request
Oct 13, 2019
ZacSweers
added a commit
to square/moshi
that referenced
this pull request
Oct 15, 2019
* Port Gson Types recursion fix for subtypeOf/supertypeOf From google/gson@a300148 First step in resolving #338 * Port Gson Type resolve() recursion fix for type variables From google/gson#1128 Resolves #338 * Capture adapter to make checkstyle happy * Move RecursiveTypesResolveTest out of internal package * Use moshi convention for tests * 2 is not 1
murillorodney62
added a commit
to murillorodney62/kotlin-codegen-android
that referenced
this pull request
Oct 12, 2022
* Port Gson Types recursion fix for subtypeOf/supertypeOf From google/gson@a300148 First step in resolving #338 * Port Gson Type resolve() recursion fix for type variables From google/gson#1128 Resolves #338 * Capture adapter to make checkstyle happy * Move RecursiveTypesResolveTest out of internal package * Use moshi convention for tests * 2 is not 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample failing code:
private static class TestType {
TestType<? super X> superType;
}
...
new Gson().getAdapter(TestType.class);